Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite: Fix missing @storybook/global dependency #22700

Merged
merged 1 commit into from
May 23, 2023
Merged

Vite: Fix missing @storybook/global dependency #22700

merged 1 commit into from
May 23, 2023

Conversation

ndelangen
Copy link
Member

Closes #22695

What I did

This package is referenced in the code, but there was no dependency in the package.json

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-assigned this May 23, 2023
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch builder-vite labels May 23, 2023
@yannbf yannbf changed the title Fix vite builder by adding a dep that was missing Builder Vite: adding missing @storybook/global dependency May 23, 2023
@chakAs3
Copy link
Contributor

chakAs3 commented May 23, 2023

HI @ndelangen i had an issue with this yesterday, May i review it and merge it if it works fine

@ndelangen
Copy link
Member Author

Yes, and Yes! @chakAs3 ! ❤️

@ndelangen ndelangen requested a review from shilman May 23, 2023 15:14
@chakAs3 chakAs3 requested review from chakAs3 and removed request for shilman May 23, 2023 15:37
@shilman shilman changed the title Builder Vite: adding missing @storybook/global dependency Vite: Fix missing @storybook/global dependency May 23, 2023
shilman
shilman reviewed May 23, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen Fix looks reasonable, but how to test? The sandbox seems to be working fine even without the change.

IanVS
IanVS approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

shilman
shilman approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging since this looks reasonable, but would be nice to have a test for this in the monorepo somehow

@shilman shilman merged commit e4e0636 into next May 23, 2023
@shilman shilman deleted the norbert/add-storybook-global-dep branch May 23, 2023 15:58
@IanVS
Copy link
Member

IanVS commented May 23, 2023

I think to test it out, you'd need to start up a sandbox with yarn storybook (dev mode).

@shilman shilman mentioned this pull request May 23, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 23, 2023
shilman added a commit that referenced this pull request May 23, 2023
@shilman
Merge pull request #22700 from storybookjs/norbert/add-storybook-glob…
6653d49 
…al-dep

Vite: Fix missing @storybook/global dependency
This was referenced May 23, 2023
Closed
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

@shilman shilman shilman approved these changes

@chakAs3 chakAs3 Awaiting requested review from chakAs3

Assignees

@ndelangen ndelangen

Labels
bug builder-vite patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: PNPM/Vite Failed to resolve import "@storybook/global"
4 participants
@ndelangen @chakAs3 @IanVS @shilman